warning workarounds, gcc4

[Jaakko Niemi]

blowfish.h:31: warning: 'class block64cipher' has virtual functions but non-virtual destructor

--- sfs1-june/crypt/blowfish.h 1999-03-26 08:21:01.000000000 +0200
+++ sfs1/crypt/blowfish.h 2005-07-27 01:38:25.000000000 +0300
@@ -30,6 +30,7 @@

class block64cipher {
public:
+ virtual ~block64cipher ();
virtual void setkey (const void *, size_t) = 0;
void setkey_sha1 (const void *, size_t);
virtual void encipher (u_int32_t *, u_int32_t *) const = 0;

cc1plus: warnings being treated as errors
xdrmisc.h: In function 'bool_t xdr_int(XDR*, void*)':
xdrmisc.h:194: warning: 'val' is used uninitialized in this function

--- sfs1-june/arpc/xdrmisc.C 2005-06-05 18:59:58.000000000 +0300
+++ sfs1/arpc/xdrmisc.C 2005-07-27 02:55:34.000000000 +0300
@@ -66,7 +66,7 @@
BOOL
xdr_int (XDR *xdrs, void *objp)
{
- u_int32_t val;
+ u_int32_t val = 0;
switch (xdrs->x_op) {
case XDR_ENCODE:
val = *static_cast<int *> (objp);

Not sure if 0 is sane figure in this case.

--j

[Jaakko Niemi]

Post by Jaakko Niemi
blowfish.h:31: warning: 'class block64cipher' has virtual functions but non-virtual destructor
--- sfs1-june/crypt/blowfish.h 1999-03-26 08:21:01.000000000 +0200
+++ sfs1/crypt/blowfish.h 2005-07-27 01:38:25.000000000 +0300
@@ -30,6 +30,7 @@
class block64cipher {
+ virtual ~block64cipher ();

Duh, make that:

+ virtual ~block64cipher () {}

--j